latest 8 messages by darkfreeway
+
[2019-09-18T21:42:42Z]
darkfreeway
nedbat: Thank you!
+
[2019-09-18T21:42:01Z]
darkfreeway
nedbat: So, there has to be a convention and a discipline around this?
+
[2019-09-18T21:41:00Z]
darkfreeway
Basically what are the best practices in this case?
+
[2019-09-18T21:40:19Z]
darkfreeway
Or should the discipline be, that developer branches out from that PR branch, and starts working on a different branch now?
+
[2019-09-18T21:39:29Z]
darkfreeway
Is there any kind of a locking mechanism for Pull Requests?
+
[2019-09-18T21:39:00Z]
darkfreeway
And when everything looks good, merges the Pull Request, but a developer who now wants to work on a different feature on the same branch, pushed new changes right before reviewer merged.
+
[2019-09-18T21:37:48Z]
darkfreeway
This kinda creates a race condition with a reviewer and the developer. Let's say reviewer wants to merge it, and spends some time reviewing the Pull Request.
+
[2019-09-18T21:36:55Z]
darkfreeway
So when someone opens a Pull Request, they still can work on that branch and still push into that branch, which is automatically reflected in the Pull Request.