+ [2015-04-15T22:19:54Z] rom1504 now /nick HatredAndSadness please
+ [2015-04-15T22:26:47Z] rom1504 heh no I wasn't born on 7 mars

message no. 89673

Posted by Kalendium in #github at 2015-04-15T15:46:29Z

;)
+ [2015-04-16T08:27:42Z] tarkus Is it OK for a project owner to amend PR's commit before merging to master (if it needs small updates), or it's better to ask the original author to modify commits in his or her PR?
+ [2015-04-16T08:28:21Z] Seveas whatever you feel like doing. I personally tend to do fixups myself if they're small to avoid waiting :)
+ [2015-04-16T08:30:38Z] canton7 tarkus, I'll almost always do some little changes - it's easier, quicker, and less painful for the contributer if I fix them up myself
+ [2015-04-16T08:30:44Z] canton7 the original contributer is still marked as the commit's author
+ [2015-04-16T08:31:05Z] canton7 .. if you turn every PR into a 10-day back-and-forth over little things, people won't contribute :P